withinPolygon: 3 point minimum and boundary testing. #3889
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3889 +/- ##
==========================================
- Coverage 90.27% 90.24% -0.04%
==========================================
Files 114 114
Lines 7578 7582 +4
==========================================
+ Hits 6841 6842 +1
- Misses 737 740 +3
Continue to review full report at Codecov.
|
flovilmart
suggested changes
May 31, 2017
Contributor
flovilmart
left a comment
flovilmart
left a comment
There was a problem hiding this comment.
A few nits here and there, otherwise, it looks great!
| if (polygon.length < 3) { | ||
| throw new Parse.Error( | ||
| Parse.Error.INVALID_JSON, | ||
| 'Polygon must have at least 3 points' |
Contributor
There was a problem hiding this comment.
can you be more explicit on that: ex:
bad $geoWithin value; $polygon should contain at least 3 GeoPoints
| case '$geoWithin': { | ||
| const polygon = constraint[key]['$polygon']; | ||
| if (!(polygon instanceof Array)) { | ||
| throw new Parse.Error(Parse.Error.INVALID_JSON, 'bad $geoWithin value'); |
Contributor
There was a problem hiding this comment.
can we be more specific here with:
bad $geoWithin value; $polygon should contain at least 3 GeoPoints
| if (polygon.length < 3) { | ||
| throw new Parse.Error( | ||
| Parse.Error.INVALID_JSON, | ||
| 'Polygon must have at least 3 points' |
Member
Author
|
I've added an additional test for open vs closed polygons. They both are supported |
flovilmart
approved these changes
May 31, 2017
Member
Author
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mongo has a 3 point minimum for $polygon and throws an error.
Also withinPolygon and withinGeoBox are inclusive
They return within and on bounds. Updated test for inclusion