Skip to content

Use LRU cache as default mechanism for caching in memory #3979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 30, 2017

Conversation

flovilmart
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jun 30, 2017

Codecov Report

Merging #3979 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3979      +/-   ##
==========================================
- Coverage   90.58%   90.57%   -0.02%     
==========================================
  Files         115      116       +1     
  Lines        7788     7797       +9     
==========================================
+ Hits         7055     7062       +7     
- Misses        733      735       +2
Impacted Files Coverage Δ
src/defaults.js 90% <ø> (ø) ⬆️
src/ParseServer.js 88.12% <100%> (ø) ⬆️
src/Adapters/Cache/LRUCache.js 100% <100%> (ø)
src/Adapters/Cache/InMemoryCacheAdapter.js 100% <100%> (ø) ⬆️
src/Push/PushWorker.js 92.72% <0%> (-1.82%) ⬇️
src/RestWrite.js 93.29% <0%> (-0.2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29c2fad...6549d44. Read the comment docs.

Copy link
Contributor

@benishak benishak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LRUCache is definitely a good choice!

acinader
acinader previously approved these changes Jun 30, 2017
Copy link
Contributor

@acinader acinader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@flovilmart
Copy link
Contributor Author

@acinader It's deployed in production now, I'll keep monitoring to check if this will be fine over time

@flovilmart flovilmart merged commit 95430bb into master Jun 30, 2017
@flovilmart flovilmart deleted the use-lru-cache-default branch June 30, 2017 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants