Allow coordinate pairs in $geoWithin/$polygon query

[madsb]

This pull requests allows for a polygon that consists of an array of basic coordinate pairs besides an array of Parse.GeoPoints.

[codecov]

Codecov Report

Merging #4064 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4064      +/-   ##
==========================================
+ Coverage    90.7%   90.71%   +0.01%     
==========================================
  Files         116      116              
  Lines        7916     7920       +4     
==========================================
+ Hits         7180     7185       +5     
+ Misses        736      735       -1

Impacted Files	Coverage Δ
src/vendor/mongodbUrl.js	100% <ø> (ø)	⬆️
...dapters/Storage/Postgres/PostgresStorageAdapter.js	96.38% <100%> (ø)	⬆️
src/Adapters/Storage/Mongo/MongoTransform.js	84.32% <100%> (+0.05%)	⬆️
src/RestWrite.js	93.16% <0%> (+0.18%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92d51de...5aabc80. Read the comment docs.

[dplewis]

Can you add support for PFPolygon?

[madsb]

@dplewis, I’m not sure I understand. Looks like the iOS SDK already supports withinPolygon queries?

[dplewis]

@madsb never mind as it would require change to all sdks

[madsb]

Ah, I see - you mean adding something like Parse.Polygon to the JS SDK? I briefly considered that but seemed like it would take a little more time than I had.

[dplewis]

Parse.Polygon is already in parse-server

[madsb]

@dplewis That's correct, but I was talking about the JS SDK.

Anyway, I think I've found a bug. When saving a Polygon object to the database, the coordinates are saved as [lat, lon] pairs. But mongo expects [lon, lat] which makes $geoIntersect queries fail.

[dplewis]

@madsb For that I'm just waiting for parse-server 2.6.0 to be released then I'll rerun the tests. It works locally.

Edited: I meant adding to this PR.

$geoWithin: {
  $polygon:  { __type: 'Polygon', coordinates:[...] },
}

[madsb]

The tests are succeeding with the test coordinates, but try running the polygon save open path with these real-life coordinates:

const coords = [[33.5746,-111.9250],[33.4769,-112.0002],[33.4761,-111.8391]];
const closed = [[33.5746,-111.9250],[33.4769,-112.0002],[33.4761,-111.8391],[33.5746,-111.9250]];

[madsb]

Alright, never mind... I was confused about the whole lat/lon lon/lat thing. GeoJSON is lon/lat, and thus I must also define lon/lat when saving my Polygon object. Pretty confusing when everything else in Parse is lat/lon 😬

[dplewis]

Yeah WGS84 is annoying. What about __type: Polygon to this PR?

$geoWithin: {
  $polygon:  { __type: 'Polygon', coordinates:[...] },
}

[madsb]

Yeah, my epiphany above has kind of invalidated this pull request, so I'll close this and open a new one with __type === 'Polygon'.

[madsb]

@dplewis #4067