Skip to content

Postgres: unhandledpromiserejectionwarning #4184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2017

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Sep 18, 2017

Closes: #4169

Handle promise when deleting object that doesn't exist

@codecov
Copy link

codecov bot commented Sep 18, 2017

Codecov Report

Merging #4184 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4184      +/-   ##
==========================================
- Coverage   92.25%   92.22%   -0.04%     
==========================================
  Files         116      116              
  Lines        8083     8085       +2     
==========================================
- Hits         7457     7456       -1     
- Misses        626      629       +3
Impacted Files Coverage Δ
...dapters/Storage/Postgres/PostgresStorageAdapter.js 96.5% <100%> (-0.11%) ⬇️
src/RestWrite.js 93.34% <0%> (-0.37%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8fd670...e6ce3a2. Read the comment docs.

@flovilmart
Copy link
Contributor

YAy! No more silly logs in the tests!

@flovilmart flovilmart merged commit 19bcfd2 into parse-community:master Sep 18, 2017
@dplewis dplewis deleted the unhandledpromise branch September 18, 2017 23:27
@dplewis
Copy link
Member Author

dplewis commented Sep 18, 2017

@flovilmart If you look at the test logs now there is an other one for PG.

UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 276): TypeError: Cannot read property '$ne' of undefined

@flovilmart
Copy link
Contributor

Yep, needs investigation, but test isn’t failing :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants