-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
The REST API key was improperly inferred from environment #4292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4292 +/- ##
=======================================
Coverage 92.45% 92.45%
=======================================
Files 118 118
Lines 8155 8155
=======================================
Hits 7540 7540
Misses 615 615
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
related question, is there a doc that explains this cli thinggie you're referring too? I looked yesterday as I was setting up a new instance and wanted to try instead of my current method, but couldn't find it.
It’s in |
I'm surprised we didn't have a test that caught this :/. Can we add something in the future to prevent this, or something similar, from recurring? |
Yeah, most probably, I could add a test that validates the definition Parse properly |
@acinader for using the CLI, actually, you can try the bootstrap script, it generates everything for you. at AmpMe, we have start our server with:
then config/dev.js
The dev.js file is loaded by the CLI and parsed accordingly. |
Thanks. |
Sorry about that, this only affects CLI users, like myself... Just shot myself in the foot...