Skip to content

db connection context fix #4453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 24, 2017
Merged

db connection context fix #4453

merged 1 commit into from
Dec 24, 2017

Conversation

vitaly-t
Copy link
Contributor

@vitaly-t vitaly-t commented Dec 24, 2017

Fixing use of the wrong connection context inside a task.

Since it is only a task, and not a transaction, the consequence is only in poor connection usage, i.e. the logic is unaffected.

fixing use of the wrong connection context inside a task
@codecov
Copy link

codecov bot commented Dec 24, 2017

Codecov Report

Merging #4453 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4453      +/-   ##
==========================================
+ Coverage   92.66%   92.68%   +0.01%     
==========================================
  Files         118      118              
  Lines        8347     8347              
==========================================
+ Hits         7735     7736       +1     
+ Misses        612      611       -1
Impacted Files Coverage Δ
...dapters/Storage/Postgres/PostgresStorageAdapter.js 96.82% <100%> (ø) ⬆️
src/RestWrite.js 93.64% <0%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0a31d2...cd43571. Read the comment docs.

@vitaly-t vitaly-t merged commit a2b2f18 into master Dec 24, 2017
@vitaly-t vitaly-t deleted the vitaly-t-patch-1 branch December 24, 2017 17:56
flovilmart pushed a commit that referenced this pull request Dec 29, 2017
fixing use of the wrong connection context inside a task
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
fixing use of the wrong connection context inside a task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants