PG: Support for multiple projection in aggregate #4469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4469 +/- ##
==========================================
- Coverage 92.71% 92.71% -0.01%
==========================================
Files 118 118
Lines 8356 8355 -1
==========================================
- Hits 7747 7746 -1
Misses 609 609
Continue to review full report at Codecov.
|
vitaly-t
reviewed
Dec 29, 2017
| @@ -1546,7 +1545,7 @@ export class PostgresStorageAdapter { | |||
| } | |||
| } | |||
|
|
|||
| const qs = `SELECT ${columns} FROM $1:name ${wherePattern} ${sortPattern} ${limitPattern} ${skipPattern} ${groupPattern}`; | |||
There was a problem hiding this comment.
Are you sure you do not need to join the column there? Or is it the default for ES6 template strings when it comes to arrays?
There was a problem hiding this comment.
Did I reject this? Sorry, I'm not quite sure what I'm doing when it comes to reviews :)
There was a problem hiding this comment.
No problem. I did join the columns here. They weren't joined before properly.
dplewis
commented
Dec 29, 2017
| @@ -1546,7 +1545,7 @@ export class PostgresStorageAdapter { | |||
| } | |||
| } | |||
|
|
|||
| const qs = `SELECT ${columns} FROM $1:name ${wherePattern} ${sortPattern} ${limitPattern} ${skipPattern} ${groupPattern}`; | |||
| const qs = `SELECT ${columns.join()} FROM $1:name ${wherePattern} ${sortPattern} ${limitPattern} ${skipPattern} ${groupPattern}`; | |||
flovilmart
pushed a commit
that referenced
this pull request
Dec 29, 2017
UnderratedDev
pushed a commit
to UnderratedDev/parse-server
that referenced
this pull request
Mar 21, 2020
This was referenced Jun 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for multiple keys in aggregate queries.
Improves Projection Tests
Lints PG adapter.