Fix "undefined property '__op'" in postgres update #4541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This causes a TypeError which becomes a regular Error,
before the update can be issued. (I think)
This happens when there is an object schema,
and there is also an unrelated field in originalUpdate
which is null or undefined.
e.g. when 'location' is a mandatory object in postgres,
and 'middleName' is an optional string,
PostgresStorageAdapter would throw when a query similar
to the below was performed:
(Object.keys(originalUpdate) would include "middleName" as a value of `k`)
query.set('location', {'country': 'US'})
query.set('middleName', undefined);
Codecov Report
@@ Coverage Diff @@
## master #4541 +/- ##
==========================================
- Coverage 92.89% 92.88% -0.02%
==========================================
Files 118 118
Lines 8448 8450 +2
==========================================
+ Hits 7848 7849 +1
- Misses 600 601 +1
Continue to review full report at Codecov.
|
dplewis
approved these changes
Feb 7, 2018
UnderratedDev
pushed a commit
to UnderratedDev/parse-server
that referenced
this pull request
Mar 21, 2020
) * Fix "undefined property '__op'" in postgres update This causes a TypeError which becomes a regular Error, before the update can be issued. (I think) This happens when there is an object schema, and there is also an unrelated field in originalUpdate which is null or undefined. e.g. when 'location' is a mandatory object in postgres, and 'middleName' is an optional string, PostgresStorageAdapter would throw when a query similar to the below was performed: (Object.keys(originalUpdate) would include "middleName" as a value of `k`) query.set('location', {'country': 'US'}) query.set('middleName', undefined); * Fix lint error
This was referenced Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This causes a TypeError which becomes a regular Error,
before the update can be issued. (I think)
This happens when there is an object schema,
and there is also an unrelated field in originalUpdate
which is null or undefined.
e.g. when 'location' is a mandatory object in postgres,
and 'middleName' is an optional string,
PostgresStorageAdapter would throw when a query similar
to the below was performed:
(Object.keys(originalUpdate) would include "middleName" as a value of
k)