Skip to content

Handle duplicate value on unique index error #4560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 9, 2018

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Feb 9, 2018

Closes: #4542

This error is already handled on object creation but not handled when object field is updated.

Will add unique indexes in future release :)

@codecov
Copy link

codecov bot commented Feb 9, 2018

Codecov Report

Merging #4560 into master will decrease coverage by 0.04%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4560      +/-   ##
==========================================
- Coverage   92.91%   92.86%   -0.05%     
==========================================
  Files         118      118              
  Lines        8450     8453       +3     
==========================================
- Hits         7851     7850       -1     
- Misses        599      603       +4
Impacted Files Coverage Δ
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 95.77% <75%> (-0.29%) ⬇️
src/RestWrite.js 93.28% <0%> (-0.37%) ⬇️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 97.12% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c16e6bb...175af3d. Read the comment docs.

@dplewis dplewis requested a review from flovilmart February 9, 2018 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants