Skip to content

Check for node version in postinstall script #4657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 16, 2018

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Mar 16, 2018

Added open collective as a bonus. #4498

I notice a lot of users still fork parse-server-example. They then update to the latest version of parse-server but their engines.node in package.json stays the same.

This will output directions to support latest version.

Added open collective as a bonus.

I notice a lot of user still fork parse-server-example. They then update to the latest version but their engines.node in package.json stays the same.

This will output directions to support latest version.
@codecov
Copy link

codecov bot commented Mar 16, 2018

Codecov Report

Merging #4657 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4657      +/-   ##
==========================================
- Coverage   92.65%   92.64%   -0.02%     
==========================================
  Files         119      119              
  Lines        8567     8567              
==========================================
- Hits         7938     7937       -1     
- Misses        629      630       +1
Impacted Files Coverage Δ
src/RestWrite.js 93.41% <0%> (-0.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6abf29d...f2f0605. Read the comment docs.

@dplewis
Copy link
Member Author

dplewis commented Mar 16, 2018

Shoutout to @reznord for making this possible

Penthouse: Check for node version in postinstall script

@dplewis dplewis merged commit a323001 into parse-community:master Mar 16, 2018
@dplewis dplewis deleted the check-node branch March 16, 2018 21:09
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
Added open collective as a bonus.

I notice a lot of user still fork parse-server-example. They then update to the latest version but their engines.node in package.json stays the same.

This will output directions to support latest version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants