Skip to content

Fix purging empty class #4676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 25, 2018
Merged

Fix purging empty class #4676

merged 2 commits into from
Mar 25, 2018

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Mar 24, 2018

Closes: #4664

Without the fix I got the following error in middleware.js.

  Failed: should not call next
      - Error: Timeout - Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL.
      - Failed: There were open connections to the server left after the test finished

@codecov
Copy link

codecov bot commented Mar 24, 2018

Codecov Report

Merging #4676 into master will increase coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4676      +/-   ##
==========================================
+ Coverage   92.64%   92.65%   +0.01%     
==========================================
  Files         119      119              
  Lines        8578     8581       +3     
==========================================
+ Hits         7947     7951       +4     
+ Misses        631      630       -1
Impacted Files Coverage Δ
src/Routers/PurgeRouter.js 81.25% <66.66%> (-3.37%) ⬇️
src/Routers/PushRouter.js 96.42% <0%> (+3.57%) ⬆️
src/Adapters/Auth/meetup.js 89.47% <0%> (+5.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7108489...1a15eaf. Read the comment docs.

@dplewis dplewis requested a review from flovilmart March 24, 2018 23:23
@dplewis dplewis merged commit 0fd8493 into parse-community:master Mar 25, 2018
@dplewis dplewis deleted the purge-fix branch March 25, 2018 13:41
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
* Fix purging empty class

* remove fit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running Schema.purge on empty table fails
2 participants