Allow creation of indices on default fields #4738
Conversation
There was a problem hiding this comment.
On principle, I’m Ok with the change. I’ll let @TylerBrock merge as he’s the DB wizard
|
@ClaireNeveu there seems be to an issue with the tests: https://travis-ci.org/parse-community/parse-server/jobs/370758303#L3202 |
|
The test isues are because it's returning back the |
If the index is created by default, then it should be there no? |
|
The index is not listed in all situations. Also if I remember correctly Parse doesn't let you manage this index which makes it more of an implementation detail. |
|
@ClaireNeveu, I’m ok updating the test so we don’t really care about the full output but just what matters :) |
Codecov Report
@@ Coverage Diff @@
## master #4738 +/- ##
==========================================
- Coverage 92.7% 92.67% -0.04%
==========================================
Files 119 119
Lines 8582 8584 +2
==========================================
- Hits 7956 7955 -1
- Misses 626 629 +3
Continue to review full report at Codecov.
|
|
@flovilmart That's a good call, I've refactored the test so it only cares about the one index. |
|
Hmm, the failing test seems to be unrelated. It works locally and has nothing to do with the change. It should also be environment-independent since the code its testing has nothing to do with the database backend. The test just seems to be flaky since it relies on timing. |
|
Yep that’s odd. Worst case I’ll merge and investigate the flaky test later. |
|
Looks good, thanks @ClaireNeveu |
* Allow creation of indexes on default fields * Update test * Try to address flaky cache test
This PR resolves #4714. Note that due to #4719 the indices this allows you to create are incorrect as of right now. Once #4719 is resolved the indices created on these fields should be correct (and useful).
CC @TylerBrock