Skip to content

Ensure users with undefined ACL are treated as readable #4795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 30, 2018
Merged

Ensure users with undefined ACL are treated as readable #4795

merged 3 commits into from
May 30, 2018

Conversation

flovilmart
Copy link
Contributor

@flovilmart flovilmart commented May 30, 2018 •
edited
Loading

@flovilmart flovilmart changed the title Ensure users with ACL set to null are treated as readable Ensure users with undefined ACL are treated as readable May 30, 2018
@flovilmart flovilmart requested a review from acinader May 30, 2018 13:43
@codecov
Copy link

codecov bot commented May 30, 2018 •
edited
Loading

Codecov Report

Merging #4795 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4795      +/-   ##
==========================================
- Coverage   92.71%   92.68%   -0.03%     
==========================================
  Files         119      119              
  Lines        8686     8686              
==========================================
- Hits         8053     8051       -2     
- Misses        633      635       +2
Impacted Files Coverage Δ
src/Routers/UsersRouter.js 93.12% <100%> (ø) ⬆️
src/Adapters/Auth/linkedin.js 81.81% <0%> (-4.55%) ⬇️
src/Adapters/Auth/facebook.js 80% <0%> (-4%) ⬇️
src/Adapters/Auth/facebookaccountkit.js 72.72% <0%> (-3.04%) ⬇️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 97.24% <0%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4422c4...832c65b. Read the comment docs.

@flovilmart flovilmart force-pushed the fix/issue-4790-login-legacy-user branch 3 times, most recently from 66ab1a9 to e33a746 Compare May 30, 2018 14:04
@flovilmart flovilmart force-pushed the fix/issue-4790-login-legacy-user branch from e33a746 to 1bd8056 Compare May 30, 2018 14:06
@flovilmart flovilmart merged commit 9bff44b into master May 30, 2018
@flovilmart flovilmart deleted the fix/issue-4790-login-legacy-user branch May 30, 2018 16:55
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
@flovilmart
Ensure users with undefined ACL are treated as readable (parse-commun…
a9cc536 
…ity#4795)

* Adds test to reproduce issue parse-community#4790

* Attempt to allow failure on node STABLE

* Use new format for apt packages
@kiarza2543 kiarza2543 mentioned this pull request Dec 12, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acinader acinader acinader approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flovilmart @acinader