Don't error when attempting to sort on an object field

[acinader]

fixes: #4805

see

parse-server/src/Controllers/DatabaseController.js

Line 414 in 3b40d22

fieldName = fieldName.split('.')[0];

There is a validation check for the name of a field to make sure that it is valid. This check is performed in both the Schema Controller and the Database Controller. In the database controller, the check is applied when an update or a find operation is requested on the database.

Since updates can occur to and find's can be performed on members of a document, it is important that the check only be performed on the name of the field, and not the member.

In the case of the update, there is an existing split that separates the field from the member.

The split is missing from the find when trying to sort on a field which is erroneously causing an error.

This pull request introduces a test to sort on a member of a document and a fix to allow the test to pass.

[acinader]

well postgress doesn't like it.

[acinader]

@vitaly-t any feedback on the postgress failure?

[codecov]

Codecov Report

Merging #4806 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4806      +/-   ##
==========================================
- Coverage   92.69%   92.69%   -0.01%     
==========================================
  Files         119      119              
  Lines        8684     8688       +4     
==========================================
+ Hits         8050     8053       +3     
- Misses        634      635       +1

Impacted Files	Coverage Δ
src/Controllers/DatabaseController.js	94.67% <100%> (+0.03%)	⬆️
...dapters/Storage/Postgres/PostgresStorageAdapter.js	97.16% <100%> (ø)	⬆️
src/RestWrite.js	93.61% <0%> (-0.19%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf3a872...549c22a. Read the comment docs.

[vitaly-t]

No, I never touched the generic database code here, only the driver-related stuff.

[dplewis]

@acinader The fix for PG should be a simple fix. Transform sortField.value into sortField ->> 'value' or something like that. I'm sure you can order by json object value.

[flovilmart]

So actually in the validation, we should allow the dot notation / transformation of this sorting no?

[dplewis]

@flovilmart I know this issue #2113 has needed addressing. I can add support for PG order by nested since mongo already does.

[flovilmart]

Go ahead, perhaps à PR on @acinader’s or use a branch on this repo so you guys can contribute together

[dplewis]

@acinader @flovilmart I added some additional test. How does this look?

[acinader]

@dplewis awesome! thanks.

@flovilmart comment added. I factored out the operation into a function and commented. Got rid of param reassignment too, bonus.

[flovilmart]

Yeah that’s better. I would probably have called it ‘rootFieldName’ but that’s ok as is :)

[acinader]

yeah, that is a lot better name. see #4817. thanks.