Skip to content

Update ws to the latest version 🚀 #4849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 25, 2018
Merged

Conversation

greenkeeper[bot]
Copy link
Contributor

@greenkeeper greenkeeper bot commented Jun 23, 2018

Version 5.2.1 of ws was just published.

Dependency [ws](https://github.com/websockets/ws)
Current Version 5.2.0
Type dependency

The version 5.2.1 is not covered by your current version range.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

It might be worth looking into these changes and trying to get this project onto the latest version of ws.

If you have a solid test suite and good coverage, a passing build is a strong indicator that you can take advantage of these changes directly by merging the proposed change into your project. If the build fails or you don’t have such unconditional trust in your tests, this branch is a great starting point for you to work on the update.


Release Notes 5.2.1

Bug fixes

  • Fixed a bug that could prevent buffered data from being processed under
    certain circumstances (6046a28).
Commits

The new version differs by 5 commits.

  • 175ce46 [dist] 5.2.1
  • 307be7a [fix] Remove the 'data' listener when the receiver emits an error
  • 6046a28 [fix] Do not prematurely remove the listener of the 'data' event
  • bf9b2ec chore(package): update nyc to version 12.0.2 (#1395)
  • bcab531 chore(package): update eslint-plugin-promise to version 3.8.0 (#1389)

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper bot 🌴

@codecov
Copy link

codecov bot commented Jun 23, 2018

Codecov Report

Merging #4849 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4849      +/-   ##
==========================================
+ Coverage   92.77%   92.78%   +0.01%     
==========================================
  Files         119      119              
  Lines        8760     8760              
==========================================
+ Hits         8127     8128       +1     
+ Misses        633      632       -1
Impacted Files Coverage Δ
...dapters/Storage/Postgres/PostgresStorageAdapter.js 97.29% <0%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64388a3...b802b85. Read the comment docs.

@flovilmart flovilmart merged commit ade5a33 into master Jun 25, 2018
@flovilmart flovilmart deleted the greenkeeper/ws-5.2.1 branch June 25, 2018 19:04
flovilmart pushed a commit that referenced this pull request Aug 12, 2018
* fix(package): update ws to version 5.2.1

* chore(package): update lockfile

https://npm.im/greenkeeper-lockfile
flovilmart pushed a commit that referenced this pull request Aug 12, 2018
* fix(package): update ws to version 5.2.1

* chore(package): update lockfile

https://npm.im/greenkeeper-lockfile
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
* fix(package): update ws to version 5.2.1

* chore(package): update lockfile

https://npm.im/greenkeeper-lockfile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants