Ensure User ACL's are more flexible and secure #3588 #4860
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s no access to the object
acinader
reviewed
Jun 28, 2018
spec/helper.js
Outdated
| @@ -114,7 +114,7 @@ if (process.env.PARSE_SERVER_TEST_CACHE === 'redis') { | |||
| } | |||
|
|
|||
| const openConnections = {}; | |||
|
|
|||
| console.log('YOLO!!!'); | |||
Codecov Report
@@ Coverage Diff @@
## master #4860 +/- ##
==========================================
- Coverage 92.81% 92.81% -0.01%
==========================================
Files 119 119
Lines 8813 8825 +12
==========================================
+ Hits 8180 8191 +11
- Misses 633 634 +1
Continue to review full report at Codecov.
|
- Improves find method so we can attempt to read for a write poking the right ACL instead of using masterKey - This ensure we do not run beforeDelete/beforeFind/beforeSave in the wrong scenarios
flovilmart
force-pushed
the
fix/user-ACL-3588
branch
from
8be466c to
deddf8d
Compare
acinader
suggested changes
Jun 28, 2018
src/Auth.js
Outdated
| @@ -21,11 +21,11 @@ function Auth({ config, isMaster = false, isReadOnly = false, user, installation | |||
|
|
|||
| // Whether this auth could possibly modify the given user id. | |||
| // It still could be forbidden via ACLs even if this returns true. | |||
| Auth.prototype.couldUpdateUserId = function(userId) { | |||
| Auth.prototype.couldUpdateUserId = function() { | |||
There was a problem hiding this comment.
so this is confusing to me now. the name couldUpdateUserId with a userId argument the way it was made sense why this would exist, but I can no longer really understand. Is this just loggedInOrMaster?
There was a problem hiding this comment.
you are right :)
src/RestQuery.js
Outdated
| throw new Parse.Error(Parse.Error.INVALID_SESSION_TOKEN, | ||
| 'This session token is invalid.'); | ||
| 'invalid session token'); |
There was a problem hiding this comment.
This is in small letters at other places, I can update it all (everywhere)
src/rest.js
Outdated
| // If we're trying to update a user without / with bad session token | ||
| if (className === '_User' | ||
| && error.code === Parse.Error.OBJECT_NOT_FOUND) { | ||
| throw new Parse.Error(Parse.Error.SESSION_MISSING, 'insuffisant auth.'); |
acinader
reviewed
Jun 28, 2018
src/rest.js
Outdated
| @@ -155,7 +155,7 @@ function handleSessionMissingError(error, className) { | |||
| // If we're trying to update a user without / with bad session token | |||
| if (className === '_User' | |||
| && error.code === Parse.Error.OBJECT_NOT_FOUND) { | |||
| throw new Parse.Error(Parse.Error.SESSION_MISSING, 'insuffisant auth.'); | |||
| throw new Parse.Error(Parse.Error.SESSION_MISSING, 'insufficient auth.'); | |||
There was a problem hiding this comment.
man, I feel bad saying this, but, can you please leading cap this....
note that the sdk is consistent
https://github.com/parse-community/Parse-SDK-JS/search?q=throw+new&unscoped_q=throw+new
but parse-server isn't, but should be
https://github.com/parse-community/parse-server/search?p=2&q=throw+new&unscoped_q=throw+new****
There was a problem hiding this comment.
no need to feel bad :)
acinader
approved these changes
Jun 28, 2018
flovilmart
added a commit
that referenced
this pull request
Aug 12, 2018
* Fixes an issue that would let the beforeDelete be called when user has no access to the object * Ensure we properly lock user - Improves find method so we can attempt to read for a write poking the right ACL instead of using masterKey - This ensure we do not run beforeDelete/beforeFind/beforeSave in the wrong scenarios * nits * Caps insufficient
flovilmart
added a commit
that referenced
this pull request
Aug 12, 2018
* Fixes an issue that would let the beforeDelete be called when user has no access to the object * Ensure we properly lock user - Improves find method so we can attempt to read for a write poking the right ACL instead of using masterKey - This ensure we do not run beforeDelete/beforeFind/beforeSave in the wrong scenarios * nits * Caps insufficient
UnderratedDev
pushed a commit
to UnderratedDev/parse-server
that referenced
this pull request
Mar 21, 2020
…arse-community#4860) * Fixes an issue that would let the beforeDelete be called when user has no access to the object * Ensure we properly lock user - Improves find method so we can attempt to read for a write poking the right ACL instead of using masterKey - This ensure we do not run beforeDelete/beforeFind/beforeSave in the wrong scenarios * nits * Caps insufficient
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys! This is a fix for a long standing issue #3588. This should ensure user ACL'S let admins roles / other users manage them, while ensuring there is no data issue lock out possibility from the user himself.
This also fixes an issue where the beforeDelete would be called when the object is not writable because we were using the masterKey. It introduces a new
isWriteon the find operation inthe DB so we can force the ACL's to use the write column (a find for an intended write).If you got test suggestions, let me know.