improves test performance on mongodb #4862
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flovilmart
force-pushed
the
test-performance
branch
from
7dbe963 to
db996bf
Compare
Codecov Report
@@ Coverage Diff @@
## master #4862 +/- ##
==========================================
- Coverage 92.82% 92.75% -0.07%
==========================================
Files 119 119
Lines 8825 8825
==========================================
- Hits 8192 8186 -6
- Misses 633 639 +6
Continue to review full report at Codecov.
|
|
can you tell me what you're doing? something like: start the server for each test instead of when the file is loaded? |
|
@acinader you're right, it was messing up with the good practices for jasmine. Also droping the DB instead of calling deleteAllClasses should save between 0 and 100ms per test, depending on the data, so that's better. |
acinader
approved these changes
Jun 29, 2018
flovilmart
added a commit
that referenced
this pull request
Aug 12, 2018
* improves test performance on mongodb * Removes unused methdos
flovilmart
added a commit
that referenced
this pull request
Aug 12, 2018
* improves test performance on mongodb * Removes unused methdos
UnderratedDev
pushed a commit
to UnderratedDev/parse-server
that referenced
this pull request
Mar 21, 2020
* improves test performance on mongodb * Removes unused methdos
This was referenced Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.