Add ability to test multiple server configurations #498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| enableAnonymousUsers = true, | ||
| oauth = {}, | ||
| serverURL, | ||
| }) { |
There was a problem hiding this comment.
Is that an accept? :D
There was a problem hiding this comment.
I like that syntax, learning ES6 at the same time you know... js/node is only my part-time pleasure.
|
Test failure seems unrelated. Open/close. |
|
that will go well with #501 ;) |
|
Yah I did this for the purpose of testing adapters easier. |
|
@drew-gross updated the pull request. |
|
@drew-gross updated the pull request. |
facebook-github-bot
added
GH Review: review-needed
and removed
GH Review: needs-revision
labels
|
Gonna skip review on this because it really only changes tests and I'm tired of fixing merge conflicts. Sorry @nlutsenko :( |
drew-gross
added a commit
that referenced
this pull request
Feb 20, 2016
Add ability to test multiple server configurations
|
All good, I love the style changes here as well.! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a little janky due to needing to blow away some global state on every server reinitialization, and not blow away other global state. So it's kinda a stop-gap solution.
Amount of time the tests take is not significantly impacted.