-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
PG: Fix updating numeric array #5251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5251 +/- ##
==========================================
- Coverage 93.88% 93.86% -0.03%
==========================================
Files 123 123
Lines 8950 8953 +3
==========================================
+ Hits 8403 8404 +1
- Misses 547 549 +2
Continue to review full report at Codecov.
|
@dplewis can you add tests for mixing text, object and numeric on updating objects? |
I don't think that is supported in Postgres unless we add something like Composite Types @vitaly-t Is it possible to have an array of multiple types in PG? I wrote a test case for it locally and it fails |
I wanted to check the failure indeed :) |
@dplewis From |
@vitaly-t Thanks, thats really helpful. I tried to do something like
But objects are stored as
Also is that filter recursive. Like if I have an array of array of mixed types? |
If you give me an example of what you are trying to achieve, I could come up with a usable example.
For an array of mixed types, each value that's a mixed type needs to implement Custom Type Formatting. And then it can be recursive also, via the same |
* PG: Fix updating numeric array * lint
Closes: #5239