Add original object to LiveQuery Events #5265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5265 +/- ##
==========================================
+ Coverage 93.87% 93.91% +0.04%
==========================================
Files 123 123
Lines 8973 8975 +2
==========================================
+ Hits 8423 8429 +6
+ Misses 550 546 -4
Continue to review full report at Codecov.
|
flovilmart
reviewed
Dec 28, 2018
src/LiveQuery/Client.js
Outdated
| @@ -92,6 +96,12 @@ class Client { | |||
| fields = this.subscriptionInfos.get(subscriptionId).fields; | |||
| } | |||
| response['object'] = this._toJSONWithFields(parseObjectJSON, fields); | |||
| if (typeof parseOriginalObjectJSON !== 'undefined') { | |||
| response['originalParseObject'] = this._toJSONWithFields( | |||
There was a problem hiding this comment.
We use ‘original’ in the before/after hooks. Can you have a look? Would be nice to preserve semantics
|
Thx! |
flovilmart
approved these changes
Dec 28, 2018
UnderratedDev
pushed a commit
to UnderratedDev/parse-server
that referenced
this pull request
Mar 21, 2020
* Add original object to LiveQuery Events * change response original
This was referenced Jun 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #5233
No breaking changes, update will be needed on the JS SDK.
will be used for update and event subscriptions