Skip to content

Prevent Stalebot from closing PRs #5416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2019
Merged

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Mar 12, 2019

Configure stalebot to only close issues

Also fixes labels

@acinader
Copy link
Contributor

Off the cuff, I feel like if we haven't worked on a pr or an issue for 50+ days, it's ok to close it? Do we ever come back to an old stale issue or pr and work it?

@acinader
Copy link
Contributor

playing devil's advocate, the fact that #5228 got marked stale is not bad cause it forces you to re-evaluate it, right?

@dplewis
Copy link
Member Author

dplewis commented Mar 12, 2019

That is true but it forced me to dig around to find it.

@codecov
Copy link

codecov bot commented Mar 12, 2019

Codecov Report

Merging #5416 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5416   +/-   ##
=======================================
  Coverage   93.91%   93.91%           
=======================================
  Files         123      123           
  Lines        9005     9005           
=======================================
  Hits         8457     8457           
  Misses        548      548
Impacted Files Coverage Δ
src/RestWrite.js 93.07% <0%> (-0.55%) ⬇️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.21% <0%> (+0.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01e8e5d...7f64cb9. Read the comment docs.

@dplewis
Copy link
Member Author

dplewis commented Mar 12, 2019

Do we ever come back to an old stale issue or pr and work it?

I usually give the authors a chance to fix the issues. After a while I clean them up.

@acinader
Copy link
Contributor

your call.

@dplewis dplewis merged commit 8622e5c into parse-community:master Mar 12, 2019
@dplewis dplewis deleted the stale-pull branch March 12, 2019 00:24
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants