Accept subdocuments keys ("object.subobject"), to allow atomic updates of an object field. #567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s of an object field.
…rver on is already in use.
|
@IlyaDiallo updated the pull request. |
…rver on is already in use. (reverted from commit 7da7c43)
|
@IlyaDiallo updated the pull request. |
gfosco
added a commit
that referenced
this pull request
Feb 26, 2016
Accept subdocuments keys ("object.subobject"), to allow atomic updates of an object field.
|
Looks good to me. 👍 |
IlyaDiallo
added a commit
to IlyaDiallo/parse-server
that referenced
this pull request
Jun 7, 2017
natanrolnik
pushed a commit
that referenced
this pull request
Jun 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The validateField function checks the key/type against the schema.
For objects fields, it's valid to set subdocuments with the dot notation syntax.
This patch changes the validateField test to allow this syntax.