Add tests for ordering by multiple fields#6316
Merged
davimacedo merged 5 commits intoparse-community:masterfrom Jan 6, 2020
Merged
Add tests for ordering by multiple fields#6316davimacedo merged 5 commits intoparse-community:masterfrom
davimacedo merged 5 commits intoparse-community:masterfrom
Conversation
An internal server error is thrown if the `order` query parameter is an array. Currently, `order` only works with a single value.
Codecov Report
@@ Coverage Diff @@
## master #6316 +/- ##
==========================================
- Coverage 93.83% 93.82% -0.02%
==========================================
Files 169 169
Lines 11588 11588
==========================================
- Hits 10874 10872 -2
- Misses 714 716 +2
Continue to review full report at Codecov.
|
dplewis
approved these changes
Jan 6, 2020
UnderratedDev
pushed a commit
to UnderratedDev/parse-server
that referenced
this pull request
Mar 21, 2020
* fix(GraphQL): Unable to run queries with order as array An internal server error is thrown if the `order` query parameter is an array. Currently, `order` only works with a single value. * Add tests * Reset cache * Remove one of the tests from Postgres Co-authored-by: Douglas Muraoka <douglas.muraoka@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regarding #6310, it looks that it is already fixed in the master:
parse-server/src/GraphQL/loaders/parseClassQueries.js
Line 127 in 5d76b2f
parse-server/src/GraphQL/loaders/parseClassTypes.js
Line 437 in a72ab50
This PR add tests to make sure it is working.