Allow to resolve automatically Parse Type fields from Custom Schema#6562
Merged
davimacedo merged 14 commits intoparse-community:masterfrom Apr 21, 2020
Merged
Conversation
Update Moumoums
Codecov Report
@@ Coverage Diff @@
## master #6562 +/- ##
==========================================
- Coverage 93.91% 93.88% -0.04%
==========================================
Files 169 169
Lines 11967 11965 -2
==========================================
- Hits 11239 11233 -6
- Misses 728 732 +4
Continue to review full report at Codecov.
|
Member
|
@Moumouls can you please add a test case? |
Member
Author
|
I will add test case soon, finally after many tests on my teams graphql parse server (with advanced GraphQL use), i figured out that a simple merge (transfer custom type to auto) combine to replace last types seems to solve all issues and all types/mutation/queries are correctly overloaded. |
Member
Author
|
Postgres fail again |
Member
Author
|
@davimacedo test case added ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An error occur when you write a custom Mutation/Query that return an auto generated type like
User,SomeClass...For example, currently it fails
So we need to inject Auto GraphQL Type fields into the custom one to return a valid
User.Also we need to avoid doing this for roots types to prevent wrong routing during schema execution.