Conversation
Codecov Report
@@ Coverage Diff @@
## master #6795 +/- ##
=======================================
Coverage 93.89% 93.89%
=======================================
Files 169 169
Lines 12054 12054
=======================================
Hits 11318 11318
Misses 736 736
Continue to review full report at Codecov.
|
|
@dplewis thanks for picking up that issue so quickly. I find some of these new formatting rules rather verbose 🧐 Would it make sense to disable a single rule like these additional parenthesis? Would that pre-commit hook then be deployed with the repo or how does this work? |
|
You would have to update |
|
Do we want the code to be that verbose, or is that verbosity only my subjective impression? I haven't seen these mandatory parentheses in other lints and find them quite unintuitive, but maybe that's just me? |
|
I also don't like these additional parentheses. I'm in for removing them. |
|
According to the docs this should work:
Let's see if there is something else we want to change... |
|
The space after function?
|
|
I think it would be better to change https://github.com/parse-community/parse-server/blob/master/.prettierrc so we don't need to send this option every time we run the command. |
|
I like the space after functions, but we can also change if you prefer. |
I'm just reading up on this. I would also write it without space, but there seem to be good arguments for having a space. |
|
Let’s keep the space |
|
It seems that there isn't even an option for space-after-function in prettier. I just scanned through the (endless) threads and the last result was a somewhat 50-50 opinion and prettier decided to make it mandatory and not optional. |
3 participants
A lot of PR are being formatted via Husky which makes review difficult.