-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Rename ExportAdapter to DatabaseController, start splitting Mongo specific logic. #698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
d78c274
Rename ExportAdapter to DatabaseController.
nlutsenko 997da89
Split mongodb connection creation from DatabaseController.
nlutsenko 7215300
Move Mongo database property directly to mongo adapter.
nlutsenko eb89283
Move and cleanup getting collections into MongoStorageAdapter.
nlutsenko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
'use strict'; | ||
|
||
let DatabaseController = require('../src/Controllers/DatabaseController'); | ||
let MongoStorageAdapter = require('../src/Adapters/Storage/Mongo/MongoStorageAdapter'); | ||
|
||
describe('DatabaseController', () => { | ||
it('can be constructed', done => { | ||
let adapter = new MongoStorageAdapter('mongodb://localhost:27017/test'); | ||
let databaseController = new DatabaseController(adapter, { | ||
collectionPrefix: 'test_' | ||
}); | ||
databaseController.connect().then(done, error => { | ||
console.log('error', error.stack); | ||
fail(); | ||
}); | ||
}); | ||
}); |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
|
||
let mongodb = require('mongodb'); | ||
let MongoClient = mongodb.MongoClient; | ||
|
||
export class MongoStorageAdapter { | ||
// Private | ||
_uri: string; | ||
// Public | ||
connectionPromise; | ||
database; | ||
|
||
constructor(uri: string) { | ||
this._uri = uri; | ||
} | ||
|
||
connect() { | ||
if (this.connectionPromise) { | ||
return this.connectionPromise; | ||
} | ||
|
||
this.connectionPromise = MongoClient.connect(this._uri).then(database => { | ||
this.database = database; | ||
}); | ||
return this.connectionPromise; | ||
} | ||
|
||
collection(name: string) { | ||
return this.connect().then(() => { | ||
return this.database.collection(name); | ||
}); | ||
} | ||
|
||
// Used for testing only right now. | ||
collectionsContaining(match: string) { | ||
return this.connect().then(() => { | ||
return this.database.collections(); | ||
}).then(collections => { | ||
return collections.filter(collection => { | ||
if (collection.namespace.match(/\.system\./)) { | ||
return false; | ||
} | ||
return (collection.collectionName.indexOf(match) == 0); | ||
}); | ||
}); | ||
} | ||
} | ||
|
||
export default MongoStorageAdapter; | ||
module.exports = MongoStorageAdapter; // Required for tests |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a comment that this is for clearing out collections during tests? I was kinda confused about why this function exists.