Skip to content

Feature: Reuse tokens if they haven't expired - #7017

Merged
davimacedo merged 6 commits into
parse-community:masterfrom
dblythy:resendExistingCode
Nov 25, 2020
Merged

Feature: Reuse tokens if they haven't expired#7017
davimacedo merged 6 commits into
parse-community:masterfrom
dblythy:resendExistingCode

Conversation

@dblythy

@dblythy dblythy commented Nov 18, 2020

Copy link
Copy Markdown
Member

Closes #7012

@codecov

codecov Bot commented Nov 18, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #7017 (28da90b) into master (8763993) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7017      +/-   ##
==========================================
- Coverage   93.83%   93.81%   -0.02%     
==========================================
  Files         169      169              
  Lines       12407    12438      +31     
==========================================
+ Hits        11642    11669      +27     
- Misses        765      769       +4
Impacted Files Coverage Δ
src/Options/Definitions.js 100.00% <ø> (ø)
src/Options/index.js 100.00% <ø> (ø)
src/Routers/UsersRouter.js 94.37% <ø> (ø)
src/Config.js 90.47% <100.00%> (+0.54%) ⬆️
src/Controllers/UserController.js 95.12% <100.00%> (+0.67%) ⬆️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.92% <0.00%> (-0.67%) ⬇️
src/RestWrite.js 93.51% <0.00%> (-0.17%) ⬇️
src/LiveQuery/ParseLiveQueryServer.js 94.92% <0.00%> (ø)
src/Adapters/Auth/ldap.js 93.87% <0.00%> (+1.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8763993...28da90b. Read the comment docs.

davimacedo
davimacedo requested changes Nov 18, 2020
View reviewed changes

@davimacedo davimacedo left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I have some comments.

Comment thread src/Controllers/UserController.js Outdated
Comment thread src/Controllers/UserController.js Outdated
@parse-community parse-community deleted a comment from dblythy Nov 18, 2020
mtrezza
mtrezza reviewed Nov 18, 2020
View reviewed changes

@mtrezza mtrezza left a comment •
edited by davimacedo
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved

davimacedo
davimacedo approved these changes Nov 19, 2020
View reviewed changes

@davimacedo davimacedo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. @mtrezza any other comment here?

@dblythy

dblythy commented Nov 19, 2020

Copy link
Copy Markdown
Member Author

Postgres tests are failing for some reason. I'll look into that.

mtrezza
mtrezza requested changes Nov 19, 2020
View reviewed changes
Comment thread spec/EmailVerificationToken.spec.js Outdated
Comment thread spec/EmailVerificationToken.spec.js Outdated
Comment thread src/Options/index.js
@davimacedo
davimacedo self-requested a review November 19, 2020 04:28
@davimacedo

davimacedo commented Nov 19, 2020

Copy link
Copy Markdown
Member

Yes. I've also just seen there is an error in Postgres tests.

@dblythy

dblythy commented Nov 19, 2020

Copy link
Copy Markdown
Member Author

I don't think it's related to this PR though:

1) Cloud Code cloud jobs should set the message / success on the job
  Message:
    Expected undefined to equal 'hello'.

@davimacedo

davimacedo commented Nov 19, 2020

Copy link
Copy Markdown
Member

Yes. The only one failing now looks the flaky one. I am re-running the tests.

@dblythy

dblythy commented Nov 19, 2020

Copy link
Copy Markdown
Member Author

Thank you Davi!!

davimacedo
davimacedo approved these changes Nov 19, 2020
View reviewed changes

@davimacedo davimacedo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are good now

mtrezza
mtrezza requested changes Nov 19, 2020
View reviewed changes
Comment thread src/Config.js
@mtrezza mtrezza mentioned this pull request Nov 23, 2020
Closed
mtrezza
mtrezza approved these changes Nov 25, 2020
View reviewed changes

@mtrezza mtrezza left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for this great addition to Parse Server 😃🚀

@davimacedo
davimacedo merged commit e88f2e3 into parse-community:master Nov 25, 2020
@dblythy
dblythy deleted the resendExistingCode branch November 27, 2020 13:28
This was referenced Feb 22, 2021
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davimacedo davimacedo davimacedo approved these changes
@mtrezza mtrezza mtrezza approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow multiple email verification codes, or resend with existing code

3 participants

@dblythy @davimacedo @mtrezza