Skip to content

Upgrade mongodb to 3.6.3 #7055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

sunshineo
Copy link
Contributor

#7048

https://jira.mongodb.org/browse/NODE-2784

Is test needed for this sort of change?

@codecov
Copy link

codecov bot commented Dec 10, 2020

Codecov Report

Merging #7055 (67e8676) into master (abdfe61) will decrease coverage by 0.64%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7055      +/-   ##
==========================================
- Coverage   93.86%   93.22%   -0.65%     
==========================================
  Files         169      169              
  Lines       12445    12445              
==========================================
- Hits        11682    11602      -80     
- Misses        763      843      +80     
Impacted Files Coverage Δ
...dapters/Cache/RedisCacheAdapter/KeyPromiseQueue.js 0.00% <0.00%> (-95.46%) ⬇️
src/Adapters/Cache/RedisCacheAdapter/index.js 12.50% <0.00%> (-82.15%) ⬇️
src/Routers/PushRouter.js 93.10% <0.00%> (-3.45%) ⬇️
src/batch.js 90.38% <0.00%> (-1.93%) ⬇️
src/ParseServerRESTController.js 96.72% <0.00%> (-1.64%) ⬇️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 91.37% <0.00%> (-1.55%) ⬇️
src/RestWrite.js 93.67% <0.00%> (-0.17%) ⬇️
src/Controllers/DatabaseController.js 95.16% <0.00%> (-0.16%) ⬇️
src/Adapters/Storage/Mongo/MongoTransform.js 88.67% <0.00%> (-0.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abdfe61...67e8676. Read the comment docs.

@mtrezza
Copy link
Member

mtrezza commented Dec 10, 2020

Can you look into the failing tests? There may be a breaking change due to the adapter upgrade.

Could you also add a failing test case that demonstrates the issue you experienced?

@dplewis
Copy link
Member

dplewis commented Dec 10, 2020

There are 2 other PRs open for this same update. I’ve had success with fixing the tests, there is one flaky test that I am looking into. @davimacedo is also looking into it

@mtrezza
Copy link
Member

mtrezza commented Dec 10, 2020

Oh, a Snyk PR, that's why there was no issue for this.

Thanks for the PR @sunshineo, I think we can close it in favor of #7026.

@mtrezza mtrezza closed this Dec 10, 2020
@sunshineo
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants