_Role object must specified name and ACL

[sdf611097]

Below curl will response {"code":135,"error":"Role names must be specified."}, but this server will success.

Code 135 not defined in JavascriptSDK 1.7.1.

curl -X POST
-H "X-Parse-Application-Id: XXXXX"
-H "X-Parse-REST-API-Key: XXXXX"
-H "Content-Type: application/json"
-d '{
"ACL": {
"*": {
"read": true
}
}
}'
https://api.parse.com/1/roles

[flovilmart]

Thanks for catching that one!

we've added a 'safer' mechanism for the required keys a few days ago, this required key should be added to here instead.

Can you also please add tests?

https://github.com/ParsePlatform/parse-server/blob/master/src/Schema.js#L75

[facebook-github-bot]

@sdf611097 updated the pull request.

[flovilmart]

@sdf611097 can you please add the name and ACL to the required columns in Schema as it also provides mechanisms to prevent deleting the value for a required column. The mechanism implemented there is fully tested.

[sdf611097]

@flovilmart
Thanks for your suggestion, I had not notice that, and I will send a commit for it.
Should I throw error with {"code":135,"error":"Role names must be specified."} (as same as current PARSE server)
or { Parse.Error.INCORRECT_TYPE, missingColumns[0]+' is required.'} ? (Schema.validateRequiredColumns)

[facebook-github-bot]

@sdf611097 updated the pull request.

[flovilmart]

Nice, leave it like that so errors are generic on the 1st missing column.

ACL should be required too AFAIK.

[facebook-github-bot]

@sdf611097 updated the pull request.

[sdf611097]

CI failed by "Parse.GeoPoint testing geo max distance large".
This test is not 100% pass.

[flovilmart]

Remove log

[facebook-github-bot]

@sdf611097 updated the pull request.