Skip to content

fix: incorrect error message key "error" instead of "message" #7448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

fn-faisal
Copy link
Member

New Pull Request Checklist

Issue Description

The Parse Server should return consistent error messages.

Approach

Update the error response to share the format code and message.

Note

Making the error message consistent would cause breaks in the existing SDKs. I've opened this PR with the basic idea and maybe a workaround can be added for existing users but locally, this already breaks the dashboard which uses the JS SDK.

Screenshot 2021-06-28 at 5 44 06 PM

Screenshot 2021-06-28 at 5 43 45 PM

@mtrezza mtrezza added type:bug Impaired feature or lacking behavior that is likely assumed and removed type:bug Impaired feature or lacking behavior that is likely assumed labels Jul 11, 2021
@mtrezza
Copy link
Member

mtrezza commented Oct 18, 2021

@fn-faisal Could you open an issue for this? I think this is a breaking change that can better be discussed in an issue. Actually there may be an existing issue for this, I remember this has been discussed recently.

@mtrezza mtrezza changed the title Parse Server should return consistent error messages #7444 fix: incorrect error message key "error" instead of "message" Oct 18, 2021
@parse-github-assistant
Copy link

Thanks for opening this pull request!

  • ❌ Please edit your post and use the provided template when creating a new pull request. This helps everyone to understand your post better and asks for essential information to quicker review the pull request.

@fn-faisal fn-faisal closed this Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants