-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
refactor: simplify Cloud Code tests and FunctionsRouter #7564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: alpha
Are you sure you want to change the base?
Conversation
Thanks for opening this pull request!
|
Woooo, what an undertaking! Refactoring is something that often stays behind unfortunately. Great that you pick this up! |
I'm happy to continue working through, just wanted to see your thoughts 😊 |
Codecov Report
@@ Coverage Diff @@
## master #7564 +/- ##
==========================================
- Coverage 93.95% 84.80% -9.16%
==========================================
Files 181 181
Lines 13328 13318 -10
==========================================
- Hits 12522 11294 -1228
- Misses 806 2024 +1218
Continue to review full report at Codecov.
|
This reverts commit ecc7d1d.
Could you please resolve the conflict? |
New Pull Request Checklist
Issue Description
Works towards making core code and spec more readable.
Related issue: #7563
Approach
Refactors existing code to better standards.
TODOs before merging