Skip to content

refactor: simplify Cloud Code tests and FunctionsRouter #7564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 18 commits into
base: alpha
Choose a base branch
from

Conversation

dblythy
Copy link
Member

@dblythy dblythy commented Sep 9, 2021

New Pull Request Checklist

Issue Description

Works towards making core code and spec more readable.

Related issue: #7563

Approach

Refactors existing code to better standards.

TODOs before merging

  • Add test cases
  • Add entry to changelog

@parse-github-assistant
Copy link

parse-github-assistant bot commented Sep 9, 2021

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@mtrezza
Copy link
Member

mtrezza commented Sep 9, 2021

Woooo, what an undertaking! Refactoring is something that often stays behind unfortunately. Great that you pick this up!

@dblythy
Copy link
Member Author

dblythy commented Sep 9, 2021

I'm happy to continue working through, just wanted to see your thoughts 😊

@dblythy dblythy marked this pull request as draft September 9, 2021 23:28
@codecov
Copy link

codecov bot commented Sep 10, 2021

Codecov Report

Merging #7564 (7402aad) into master (68a3a87) will decrease coverage by 9.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7564      +/-   ##
==========================================
- Coverage   93.95%   84.80%   -9.16%     
==========================================
  Files         181      181              
  Lines       13328    13318      -10     
==========================================
- Hits        12522    11294    -1228     
- Misses        806     2024    +1218     
Impacted Files Coverage Δ
src/Routers/FunctionsRouter.js 100.00% <100.00%> (+5.88%) ⬆️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 2.47% <0.00%> (-92.90%) ⬇️
src/Adapters/Storage/Postgres/PostgresClient.js 5.00% <0.00%> (-65.00%) ⬇️
src/Controllers/UserController.js 95.34% <0.00%> (-2.33%) ⬇️
src/Controllers/FilesController.js 92.00% <0.00%> (-2.00%) ⬇️
src/Controllers/index.js 96.66% <0.00%> (-1.12%) ⬇️
src/Routers/UsersRouter.js 93.82% <0.00%> (-0.57%) ⬇️
src/middlewares.js 96.92% <0.00%> (-0.44%) ⬇️
src/RestWrite.js 93.73% <0.00%> (-0.32%) ⬇️
src/Controllers/SchemaController.js 97.16% <0.00%> (-0.19%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68a3a87...7402aad. Read the comment docs.

@dblythy dblythy marked this pull request as ready for review September 10, 2021 00:42
@mtrezza mtrezza changed the title Cleanup Cloud Code refactor: simplify Cloud Code tests and FunctionsRouter Sep 13, 2021
@mtrezza
Copy link
Member

mtrezza commented Sep 14, 2021

Could you please resolve the conflict?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants