Skip to content

revert: refactor: allow ES import for cloud string if package type is module #7689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mtrezza
Copy link
Member

@mtrezza mtrezza commented Nov 10, 2021

This reverts commit 0225340.

See #7680

@parse-github-assistant
Copy link

parse-github-assistant bot commented Nov 10, 2021

Thanks for opening this pull request!

  • ❌ Please edit your post and use the provided template when creating a new pull request. This helps everyone to understand your post better and asks for essential information to quicker review the pull request.

@codecov
Copy link

codecov bot commented Nov 10, 2021

Codecov Report

Merging #7689 (136efd7) into alpha (611bd9b) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head 136efd7 differs from pull request most recent head c8206cd. Consider uploading reports for the commit c8206cd to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##            alpha    #7689      +/-   ##
==========================================
- Coverage   93.90%   93.87%   -0.04%     
==========================================
  Files         183      183              
  Lines       13626    13624       -2     
==========================================
- Hits        12796    12789       -7     
- Misses        830      835       +5     
Impacted Files Coverage Δ
src/ParseServer.js 90.05% <100.00%> (-0.11%) ⬇️
src/batch.js 91.37% <0.00%> (-1.73%) ⬇️
src/ParseServerRESTController.js 97.01% <0.00%> (-1.50%) ⬇️
src/Adapters/Files/GridFSBucketAdapter.js 79.50% <0.00%> (-0.82%) ⬇️
src/RestWrite.js 93.88% <0.00%> (-0.32%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 611bd9b...c8206cd. Read the comment docs.

@mtrezza mtrezza changed the title revert: allow ES import for cloud string if package type is module revert: refactor: allow ES import for cloud string if package type is module Nov 10, 2021
@mtrezza mtrezza merged commit b64640c into parse-community:alpha Nov 10, 2021
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0-alpha.6

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Nov 10, 2021
@mtrezza mtrezza deleted the revert-cloud-code-module-import branch November 10, 2021 15:31
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0-beta.10

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Mar 15, 2022
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.1.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants