refactor: upgrade parse from 3.4.2 to 3.4.3 #8113
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snyk has created this PR to upgrade parse from 3.4.2 to 3.4.3. See this package in npm: https://www.npmjs.com/package/parse See this project in Snyk: https://app.snyk.io/org/acinader/project/21343059-02d9-4182-87d7-718a44b181ef?utm_source=github&utm_medium=referral&page=upgrade-pr
Thanks for opening this pull request!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
Issue Description
Following the update to Parse JS which is mainly the improvement of https://github.com/parse-community/Parse-SDK-JS/pull/1467/files, stricter regex is required for creating a file from
base64.Parse Server internally creates a file to pass to triggers, using
req.body.toString("base64")and then creates a file from base64. This can cause the new regex to fail.Related issue: #8110
Approach
This PR instead creates a Parse File from the
dataarray fromBuffer, rather than converting tobase64.TODOs before merging