Skip to content

docs: Change API docs template to jsdoc-clean-theme #8519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 29, 2023
Merged

docs: Change API docs template to jsdoc-clean-theme #8519

merged 5 commits into from
Apr 29, 2023

Conversation

coratgerl
Copy link
Contributor

@coratgerl coratgerl commented Apr 27, 2023

Pull Request

Issue

Closes: #8017

Approach

Modernize the API doc template with jdoc-clean-theme.

Tasks

  • Add changes to documentation (guides, repository pages, code comments)

Changes

I had to fix some documentation to avoid duplicate Modules or duplicate class 🙂

Before :
image

After:

image

image

image

@parse-github-assistant
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title feat: update docs to jsdoc-clean-theme feat: Update docs to jsdoc-clean-theme Apr 27, 2023
@parse-github-assistant
Copy link

Thanks for opening this pull request!

Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up!

@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (177891e) 94.33% compared to head (7b0a6c3) 94.33%.

❗ Current head 7b0a6c3 differs from pull request most recent head 4e29c37. Consider uploading reports for the commit 4e29c37 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##            alpha    #8519      +/-   ##
==========================================
- Coverage   94.33%   94.33%   -0.01%     
==========================================
  Files         183      183              
  Lines       14515    14515              
==========================================
- Hits        13693    13692       -1     
- Misses        822      823       +1     
Impacted Files Coverage Δ
src/Adapters/Analytics/AnalyticsAdapter.js 50.00% <ø> (ø)
src/Adapters/Cache/CacheAdapter.js 100.00% <ø> (ø)
src/Adapters/Email/MailAdapter.js 100.00% <ø> (ø)
src/Adapters/Files/FilesAdapter.js 100.00% <ø> (ø)
src/Adapters/Logger/LoggerAdapter.js 100.00% <ø> (ø)
src/Adapters/PubSub/PubSubAdapter.js 100.00% <ø> (ø)
src/Adapters/Push/PushAdapter.js 66.66% <ø> (ø)
src/Adapters/WebSocketServer/WSSAdapter.js 100.00% <ø> (ø)
src/Security/Check.js 100.00% <ø> (ø)
src/Security/CheckGroup.js 100.00% <ø> (ø)
... and 4 more

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@coratgerl
Copy link
Contributor Author

coratgerl commented Apr 27, 2023

There are a lot of configurable options for jsdoc-clean-theme. We can customize it as you like :)

https://github.com/ankitskvmdam/clean-jsdoc-theme#options

@mtrezza
Copy link
Member

mtrezza commented Apr 27, 2023

Well, just the color scheme seems to be a bit off. The "Parse Blue" seems somewhat missing. Is there a way to configure colors?

Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you take a look at why the definitions check fails? You could run npm run definitions and see what files change.

@coratgerl
Copy link
Contributor Author

coratgerl commented Apr 28, 2023

Well, just the color scheme seems to be a bit off. The "Parse Blue" seems somewhat missing. Is there a way to configure colors?

I can add style to all html elements. I propose something like that :
image

@coratgerl
Copy link
Contributor Author

coratgerl commented Apr 28, 2023

Could you take a look at why the definitions check fails? You could run npm run definitions and see what files change.

I run : npm run definitions. It would not see any files change

@mtrezza
Copy link
Member

mtrezza commented Apr 28, 2023

The color changes in the screenshot above look good!

Could you post here what these changes are in the definition files? This PR shouldn't cause any changes there actually.

@coratgerl
Copy link
Contributor Author

coratgerl commented Apr 28, 2023

It's weird in local the npm run ci:definitionsCheck not fail. I don't see any change after the run definitions, just the files write by the prettier 🤔

Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Definitions check passed this time, not sure why it failed previously.

Is this ready for merge?

@mtrezza mtrezza changed the title feat: Update docs to jsdoc-clean-theme docs: Change API docs template to jsdoc-clean-theme Apr 29, 2023
@coratgerl
Copy link
Contributor Author

coratgerl commented Apr 29, 2023

It's ready for me :). Thanks for the feedbacks ;). You can also close this PR as long as you are the (same subject) #8021

@mtrezza mtrezza mentioned this pull request Apr 29, 2023
3 tasks
@mtrezza mtrezza merged commit 9e43bc2 into parse-community:alpha Apr 29, 2023
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.1.0-alpha.8

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label May 1, 2023
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.1.0-beta.2

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label May 1, 2023
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.1.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modernize API doc template
3 participants