-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
docs: Change API docs template to jsdoc-clean-theme #8519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I will reformat the title to use the proper commit message syntax. |
Thanks for opening this pull request! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for picking this up!
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## alpha #8519 +/- ##
==========================================
- Coverage 94.33% 94.33% -0.01%
==========================================
Files 183 183
Lines 14515 14515
==========================================
- Hits 13693 13692 -1
- Misses 822 823 +1
☔ View full report in Codecov by Sentry. |
There are a lot of configurable options for jsdoc-clean-theme. We can customize it as you like :) https://github.com/ankitskvmdam/clean-jsdoc-theme#options |
Well, just the color scheme seems to be a bit off. The "Parse Blue" seems somewhat missing. Is there a way to configure colors? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you take a look at why the definitions check fails? You could run npm run definitions
and see what files change.
I run : |
The color changes in the screenshot above look good! Could you post here what these changes are in the definition files? This PR shouldn't cause any changes there actually. |
It's weird in local the npm run ci:definitionsCheck not fail. I don't see any change after the run definitions, just the files write by the prettier 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Definitions check passed this time, not sure why it failed previously.
Is this ready for merge?
It's ready for me :). Thanks for the feedbacks ;). You can also close this PR as long as you are the (same subject) #8021 |
🎉 This change has been released in version 6.1.0-alpha.8 |
🎉 This change has been released in version 6.1.0-beta.2 |
🎉 This change has been released in version 6.1.0 |
Pull Request
Issue
Closes: #8017
Approach
Modernize the API doc template with jdoc-clean-theme.
Tasks
Changes
I had to fix some documentation to avoid duplicate Modules or duplicate class 🙂
Before :

After: