fix: Server does not start via CLI when auth option is set
#8666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening this pull request! |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## alpha #8666 +/- ##
=======================================
Coverage 94.37% 94.38%
=======================================
Files 185 185
Lines 14758 14758
=======================================
+ Hits 13928 13929 +1
+ Misses 830 829 -1
☔ View full report in Codecov by Sentry. |
|
@FransGH would you be willing to try this PR out and let us know if it resolves the issue you’ve had? Let me know if you’d like another PR based on the LTS branch, I’d be happy to sort that out.
|
|
@dblythy thx, I'll try it out on staging now! |
|
@dblythy couldn't get it working yet, likely has nothing to do with the PR. When I replace v5.5.1 with "dblythy/parse-server#fix-auth-parser" I'm getting: "WARNING, Unable to connect to 'http://localhost:1340/sel'. Cloud code and push notifications may be unavailable"! Need to go now but will try to get your branch running asap. Is the LTS branch "5.5.x" or what release is your fork based on? |
|
This PR is based on Parse Server 6, I can pretty easily create another PR based on the LTS branch. I'll have that for you tomorrow. |
mtrezza
changed the title
auth option is set
mtrezza
changed the title
auth option is setauth option set
mtrezza
changed the title
auth option setauth option is set
3 tasks
mtrezza
requested changes
Jun 28, 2023
mtrezza
reviewed
Jun 29, 2023
parseplatformorg
pushed a commit
that referenced
this pull request
Jul 4, 2023
# [6.3.0-alpha.4](6.3.0-alpha.3...6.3.0-alpha.4) (2023-07-04) ### Bug Fixes * Server does not start via CLI when `auth` option is set ([#8666](#8666)) ([4e2000b](4e2000b))
|
🎉 This change has been released in version 6.3.0-alpha.4 |
parseplatformorg
pushed a commit
that referenced
this pull request
Sep 16, 2023
# [6.4.0-beta.1](6.3.0...6.4.0-beta.1) (2023-09-16) ### Bug Fixes * Parse Server option `fileUpload.fileExtensions` does not work with an array of extensions ([#8688](#8688)) ([6a4a00c](6a4a00c)) * Redis 4 does not reconnect after unhandled error ([#8706](#8706)) ([2b3d4e5](2b3d4e5)) * Remove config logging when launching Parse Server via CLI ([#8710](#8710)) ([ae68f0c](ae68f0c)) * Server does not start via CLI when `auth` option is set ([#8666](#8666)) ([4e2000b](4e2000b)) ### Features * Add conditional email verification via dynamic Parse Server options `verifyUserEmails`, `sendUserEmailVerification` that now accept functions ([#8425](#8425)) ([44acd6d](44acd6d)) * Add property `Parse.Server.version` to determine current version of Parse Server in Cloud Code ([#8670](#8670)) ([a9d376b](a9d376b)) * Add TOTP authentication adapter ([#8457](#8457)) ([cc079a4](cc079a4)) ### Performance Improvements * Improve performance of recursive pointer iterations ([#8741](#8741)) ([45a3ed0](45a3ed0))
|
🎉 This change has been released in version 6.4.0-beta.1 |
parseplatformorg
pushed a commit
that referenced
this pull request
Sep 20, 2023
# [6.4.0-alpha.1](6.3.0...6.4.0-alpha.1) (2023-09-20) ### Bug Fixes * Parse Server option `fileUpload.fileExtensions` does not work with an array of extensions ([#8688](#8688)) ([6a4a00c](6a4a00c)) * Redis 4 does not reconnect after unhandled error ([#8706](#8706)) ([2b3d4e5](2b3d4e5)) * Remove config logging when launching Parse Server via CLI ([#8710](#8710)) ([ae68f0c](ae68f0c)) * Server does not start via CLI when `auth` option is set ([#8666](#8666)) ([4e2000b](4e2000b)) ### Features * Add conditional email verification via dynamic Parse Server options `verifyUserEmails`, `sendUserEmailVerification` that now accept functions ([#8425](#8425)) ([44acd6d](44acd6d)) * Add context to Cloud Code Triggers `beforeLogin` and `afterLogin` ([#8724](#8724)) ([a9c34ef](a9c34ef)) * Add property `Parse.Server.version` to determine current version of Parse Server in Cloud Code ([#8670](#8670)) ([a9d376b](a9d376b)) * Add TOTP authentication adapter ([#8457](#8457)) ([cc079a4](cc079a4)) ### Performance Improvements * Improve performance of recursive pointer iterations ([#8741](#8741)) ([45a3ed0](45a3ed0))
|
🎉 This change has been released in version 6.4.0-alpha.1 |
parseplatformorg
pushed a commit
that referenced
this pull request
Nov 16, 2023
# [6.4.0](6.3.1...6.4.0) (2023-11-16) ### Bug Fixes * Parse Server option `fileUpload.fileExtensions` does not work with an array of extensions ([#8688](#8688)) ([6a4a00c](6a4a00c)) * Redis 4 does not reconnect after unhandled error ([#8706](#8706)) ([2b3d4e5](2b3d4e5)) * Remove config logging when launching Parse Server via CLI ([#8710](#8710)) ([ae68f0c](ae68f0c)) * Server does not start via CLI when `auth` option is set ([#8666](#8666)) ([4e2000b](4e2000b)) ### Features * Add conditional email verification via dynamic Parse Server options `verifyUserEmails`, `sendUserEmailVerification` that now accept functions ([#8425](#8425)) ([44acd6d](44acd6d)) * Add property `Parse.Server.version` to determine current version of Parse Server in Cloud Code ([#8670](#8670)) ([a9d376b](a9d376b)) * Add TOTP authentication adapter ([#8457](#8457)) ([cc079a4](cc079a4)) ### Performance Improvements * Improve performance of recursive pointer iterations ([#8741](#8741)) ([45a3ed0](45a3ed0))
|
🎉 This change has been released in version 6.4.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue
Auth settings cannot be defined by json.
Closes: #8665
Approach
First commit is a failing test
Tasks