-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
test: Investigate flaky tests by turning off tests randomizer #9181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for opening this pull request! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## alpha #9181 +/- ##
==========================================
+ Coverage 93.78% 94.16% +0.37%
==========================================
Files 186 186
Lines 14729 14729
==========================================
+ Hits 13814 13869 +55
+ Misses 915 860 -55 ☔ View full report in Codecov by Sentry. |
@mtrezza All the test passed! |
Just FYI,
Per documentation https://nodejs.org/api/net.html#serverclosecallback The promise never resolved which lead to timeouts and if it did resolve in the middle of a test we get
|
Good investigation! |
🎉 This change has been released in version 7.1.0-alpha.15 |
🎉 This change has been released in version 7.2.0-beta.1 |
🎉 This change has been released in version 7.2.0 |
Pull Request
Issue
Attempt to fix flaky tests when the server isn't properly initialized. I believe this is caused by tests that shuts down the server to reproduce a disconnection and restarts. I am unable to reproduce this issue local so the CI should be ran a few times to ensure it works.
Closes: #9149
Approach
encodeParseObjectInCloudFunction
by defaultTasks