Skip to content

ci: Fix CI not testing with Postgres 16 and flaky test #9210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 17, 2024
Merged

ci: Fix CI not testing with Postgres 16 and flaky test #9210

merged 6 commits into from
Jul 17, 2024

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Jul 17, 2024 •
edited
Loading

Pull Request

Issue

Installed PG 15 instead of 16 as documented

Closes: #8613
Closes: #9107
Closes: #9110

Approach

  • Cleaned up TestUtils and Suite
  • Attempt to remove flaky tests
  • Add proper PG 16 image
  • Update pg-promise to 11.9.1
  • Update pg-monitor to 2.1.0

@parse-github-assistant Parse GitHub Assistant
Copy link

parse-github-assistant bot commented Jul 17, 2024 •
edited
Loading

Thanks for opening this pull request!

@codecov Codecov
Copy link

codecov bot commented Jul 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.46%. Comparing base (f384767) to head (9c26e74).
Report is 45 commits behind head on alpha.

Additional details and impacted files 
@@            Coverage Diff             @@
##            alpha    #9210      +/-   ##
==========================================
- Coverage   94.14%   93.46%   -0.69%     
==========================================
  Files         186      186              
  Lines       14751    14762      +11     
==========================================
- Hits        13888    13797      -91     
- Misses        863      965     +102

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dplewis dplewis requested a review from a team July 17, 2024 14:48
@dplewis
Copy link
Member Author

dplewis commented Jul 17, 2024

@mtrezza I think this fixes that last flaky test

@mtrezza mtrezza changed the title feat: Add support for Postgres 16 ci: Fix CI not testing with Postgres 16 and flaky test Jul 17, 2024
@mtrezza mtrezza merged commit 5fa58fe into parse-community:alpha Jul 17, 2024
24 checks passed
@dplewis dplewis deleted the pg-16 branch July 17, 2024 16:11
@dplewis dplewis mentioned this pull request Jul 17, 2024
Merged
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 7.3.0-alpha.3

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Jul 17, 2024
@dplewis dplewis mentioned this pull request Jul 20, 2024
Merged
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 7.3.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Oct 3, 2024
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 7.3.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrezza mtrezza mtrezza left review comments

Assignees
No one assigned
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix flaky Postgres tests
3 participants
@dplewis @parseplatformorg @mtrezza