hey team, comment trigger was sending invalid json for the zondax /bot dispatch#365
Open
mooncitydev wants to merge 1 commit intopaseo-network:mainfrom
Open
hey team, comment trigger was sending invalid json for the zondax /bot dispatch#365mooncitydev wants to merge 1 commit intopaseo-network:mainfrom
mooncitydev wants to merge 1 commit intopaseo-network:mainfrom
Conversation
… dispatch payload was invalid json (only one closing brace so the root object was never finished). the api would have returned 400, so the zondax remote test probably never got triggered from /bot comments. rebuilt the body with jq so the structure is always valid and the comment text is passed through --arg and env, so a /bot line with double quotes in it does not blow up the shell line anymore. also removed the old debug echo that used a variable that was never set in that step so it never printed anything useful. cheers Made-with: Cursor
mooncitydev
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hey paseo team, checked the comment trigger workflow and found the github workflow_dispatches request body was not valid json: there was a single
}at the end so the outer object from the opening{on the-dline was never closed. the repositories dispatch api typically answers with 400 for that, so the zondax remote test job likely never started from/bot... comments.fix: build the body with
jqso the shape is always valid, and pass the pr comment with--argplus env vars so shell quoting and double quotes in the text do not corrupt the request.while here removed the
echothat referenced a never-setcommandvar (it was not the output name, so the line was a no-op for debugging).cheers