Skip to content

support PSR-20 ClockInterface #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 30, 2022
Merged

support PSR-20 ClockInterface #334

merged 1 commit into from
Nov 30, 2022

Conversation

DavidBadura
Copy link
Member

@DavidBadura DavidBadura commented Nov 25, 2022

@DavidBadura DavidBadura added the enhancement New feature or request label Nov 25, 2022
@DavidBadura DavidBadura added this to the 2.1.0 milestone Nov 25, 2022
@github-actions
Copy link

Hello 👋

here is the most recent benchmark result:

LoadEventsWithSnapshotsBench
============================

Average iteration times by variant

318.8μs   │ █▆ 
279.0μs   │ ██ 
239.1μs   │ ██ 
199.3μs   │ ██ 
159.4μs   │ ██ 
119.6μs   │ ██ 
79.7μs    │ ██ 
39.8μs    │ ██ 
          └────
            1  

[█ <current>] [█ base] 

1: benchLoadEvents 

Memory by variant

14.6mb    │ ██ 
12.8mb    │ ██ 
11.0mb    │ ██ 
9.1mb     │ ██ 
7.3mb     │ ██ 
5.5mb     │ ██ 
3.7mb     │ ██ 
1.8mb     │ ██ 
          └────
            1  

[█ <current>] [█ base] 

1: benchLoadEvents 

+--------------------+--------------------+--------------------+-----------------+------------+
|                    | time (kde mode)                         | memory                       |
+--------------------+--------------------+--------------------+-----------------+------------+
| subject            | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+--------------------+--------------------+--------------------+-----------------+------------+
| benchLoadEvents () | 318.800μs (±5.96%) | 305.791μs (±1.47%) | 14.640mb        | 14.638mb   |
+--------------------+--------------------+--------------------+-----------------+------------+

WriteEventsBench
================

Average iteration times by variant

51.8ms    │    ██ 
45.3ms    │    ██ 
38.8ms    │    ██ 
32.4ms    │    ██ 
25.9ms    │    ██ 
19.4ms    │    ██ 
12.9ms    │    ██ 
6.5ms     │ ▂▂ ██ 
          └───────
            1  2  

[█ <current>] [█ base] 

1: benchSaveOneEvent    2: benchSaveAfterThous᠁ 

Memory by variant

7.5mb     │ ▃▃ ██ 
6.5mb     │ ██ ██ 
5.6mb     │ ██ ██ 
4.7mb     │ ██ ██ 
3.7mb     │ ██ ██ 
2.8mb     │ ██ ██ 
1.9mb     │ ██ ██ 
931.7kb   │ ██ ██ 
          └───────
            1  2  

[█ <current>] [█ base] 

1: benchSaveOneEvent    2: benchSaveAfterThous᠁ 

+---------------------------------+-------------------+-------------------+-----------------+------------+
|                                 | time (kde mode)                       | memory                       |
+---------------------------------+-------------------+-------------------+-----------------+------------+
| subject                         | Tag: <current>    | Tag: base         | Tag: <current>  | Tag: base  |
+---------------------------------+-------------------+-------------------+-----------------+------------+
| benchSaveOneEvent ()            | 1.383ms (±1.85%)  | 1.390ms (±1.57%)  | 6.761mb         | 6.759mb    |
| benchSaveAfterThousandEvents () | 51.788ms (±0.87%) | 51.257ms (±0.37%) | 7.453mb         | 7.452mb    |
+---------------------------------+-------------------+-------------------+-----------------+------------+

LoadEventsBench
===============

Average iteration times by variant

112.5ms   │ ██ 
98.5ms    │ ██ 
84.4ms    │ ██ 
70.3ms    │ ██ 
56.3ms    │ ██ 
42.2ms    │ ██ 
28.1ms    │ ██ 
14.1ms    │ ██ 
          └────
            1  

[█ <current>] [█ base] 

1: benchLoadEvents 

Memory by variant

24.2mb    │ ██ 
21.2mb    │ ██ 
18.2mb    │ ██ 
15.2mb    │ ██ 
12.1mb    │ ██ 
9.1mb     │ ██ 
6.1mb     │ ██ 
3.0mb     │ ██ 
          └────
            1  

[█ <current>] [█ base] 

1: benchLoadEvents 

+--------------------+--------------------+--------------------+-----------------+------------+
|                    | time (kde mode)                         | memory                       |
+--------------------+--------------------+--------------------+-----------------+------------+
| subject            | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+--------------------+--------------------+--------------------+-----------------+------------+
| benchLoadEvents () | 112.479ms (±0.18%) | 112.536ms (±1.57%) | 24.243mb        | 24.242mb   |
+--------------------+--------------------+--------------------+-----------------+------------+

This comment gets update everytime a new commit comes in!

@DavidBadura DavidBadura changed the title add psr clock support psr-20 ClockInterface Nov 25, 2022
@DavidBadura DavidBadura changed the title support psr-20 ClockInterface support PSR-20 ClockInterface Nov 25, 2022
Copy link
Member

@DanielBadura DanielBadura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About the BC-Break, will try to investigate this and maybe report upstream.

Copy link
Member

@DanielBadura DanielBadura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I mentioned reproduced the wrong BC-Break upstream and workin on a fix for that. So we can merge this here since it's not a bc-break.

@DavidBadura DavidBadura merged commit 8adb14c into 2.1.x Nov 30, 2022
@DavidBadura DavidBadura deleted the psr-clock branch November 30, 2022 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants