-
Notifications
You must be signed in to change notification settings - Fork 6
DCB #763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 3.12.x
Are you sure you want to change the base?
DCB #763
Conversation
Hello 👋 here is the most recent benchmark result:
This comment gets update everytime a new commit comes in! |
use function class_exists; | ||
|
||
/** @experimental */ | ||
trait EventRouter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this might be misleading from the naming pov, as this is not really a router implementation in a classical way. Here we have mixed in apply logic (maybe this can be called routing) and query building / filtering. That being said: I come not with a better name 🤣
Maybe we should add a require-implements
for the Projection
interface here.
Ref: https://phpstan.org/writing-php-code/phpdocs-basics#enforcing-implementing-an-interface-for-traits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i added require-implements
, I still have to think about the name.
Implement Dynamic Consistency Boundary according to https://dcb.events/.
The following examples were partially implemented:
There are still some questions open:
EventTagExtractor
must handle value objects. The current implementation requires PHP's Stringable interface, which requires a__toString()
method. Since this can lead to problems, we need an alternative.