Add support for appropriate GOMAXPROCS that's aware of Kubernetes limits. #136
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
http-server
is run with Kubernetes resource requests/limits, the limits seen by the container are not the same limits set in theresources:
section. It's a longstanding issue in the Go community where on a CFS scheduler, Go mistakenly takes the value of the host not the value provided by CFS.This is a very simple change that imports Uber's
gomaxprocs
package which automatically configures these values if they're running inside container with a CFS scheduler.