Skip to content

\PatternLab\Config::setOption() won't set to a falsey value #172

Open
@andriokha

Description

@andriokha

Hi,

Thanks for this fantastic product!!

I'm new to PL and in writing a listener plugin I wanted to create a test that could update a configuration option to false. It doesn't work because at the start of \PatternLab\Config::setOption() there's this:

if (empty($optionName) || empty($optionValue)) {
return false;
}

Also \PatternLab\Config::updateOption() just passes through to ::setOption().

It's quite an explicit check, so I guess it is/was there for a reason, but I'm not sure what that might be (:

Is that a bug? Am I doing things wrong?!

TIA

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions