Add Utilization Chart directive with ng-docs and unit tests. #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @description | ||
| * Directive for rendering a utilization chart. The utilization chart combines overall data with a pfDonutPctChart and | ||
| * a pfSparklineChart. Add the options for the pfDonutChart | ||
| * <br><br> |
There was a problem hiding this comment.
Sentence fragment? "Add the options for the pfDonutChart"?
|
LGTM |
|
I'm unsure how atomic y'all want your PRs to be but the changes to donut-pct-chart-directive.js seem a little out of place in a PR that is described as being about adding a new utilization chart feature. |
Upon further inspection it appears as if perhaps those changes were necessary for this PR so disregard this comment. |
jeff-phillips-18
force-pushed
the
master
branch
2 times, most recently
from
f2a14a8 to
f40bafe
Compare
erundle
pushed a commit
that referenced
this pull request
Aug 24, 2015
Add Utilization Chart directive with ng-docs and unit tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a Utilization Chart directive with its ng-docs and unit tests.
I needed to update the donut-pct-chart directive to allow the center label to use 2-way binding and fixed an issue where the percent shown was not being rounded off in all instances.