Upgrade to Angular 1.3 Only #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -302,7 +304,7 @@ angular.module('patternfly.card').directive('pfCard', function () { | |||
| $scope.updateAvailable(); | |||
| $scope.chartConfig.data.columns = [["Used",$scope.used],["Available",$scope.available]]; | |||
| }; | |||
| } | |||
| }]); | |||
There was a problem hiding this comment.
Nitpick: these closing brackets and the parenthesis don't line up with the angular.module above. This is also visible in the docs examples.
|
LGTM |
|
Looks good to me minus the aforementioned nitpick. |
|
+1 |
|
LGTM 👍 |
jeff-phillips-18
added a commit
that referenced
this pull request
Aug 25, 2015
Upgrade to Angular 1.3 Only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the project to support angular 1.3+. This required updating ngDocs and fixing the example code since angular did not like the previous "function" definition.
I made this change since we are looking in the future to add angular-bootstrap 1.3 to this project and angular 1.3 is a required.
Side Note: I also fixed a previous existing bug with warning/danger icons not showing up for notifications. This was discovered during the test of this update.