Fixes #34: add ng-annotate to build process. #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've ran into issues before with ng-annotate not working with controllers embedded inside a directive. Any idea it that is still a limitation? Otherwise it LGTM. |
Are you talking about this olov/ng-annotate#62? If so I can upgrade the version of ng-annotate we are using in order to address this issue. |
|
Yes please upgrade it. I have found that it leads to much confusion when that one use case doesn't work. |
Using ng-annotate in the build process so the verbose, array style, function declarations are no longer needed. Instead they are added automatically during the build process. Also fix the tabbing on some of the examples in the comments.
|
@erundle updated. |
|
Are we good to merge this (I don't have the ability)? |
erundle
pushed a commit
that referenced
this pull request
Aug 27, 2015
Fixes #34: add ng-annotate to build process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using ng-annotate in the build process so the verbose, array style,
function declarations are no longer needed. Instead they are added
automatically during the build process.
Also fix the tabbing on some of the examples in the comments.