chore(pfTableView): Fix compile warnings #716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…View with Toolbar due to spaces, and fix non camel case lint error in Gruntfile.js
amarie401
approved these changes
Feb 19, 2018
TheRealJon
approved these changes
Feb 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For ngdoc linking to pfTableView with Toolbar due to spaces. Omit spaces in ngdoc @name so links are not throwing warnings
Fix non camel case lint error in Gruntfile.js: Omit the check for camel case function for convert_within_custom_replacements task.
Description
The goal of this pr is to omit all warnings from the build, and is a fix for:
#713
No coding changes for unit test coverage, no visual changes needing screenshots, a designer or css rep.
PR Checklist