Replace dynamic dynCall by makeDynCall macro #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears
dynCallhas been converted into a library function in emscripten-core/emscripten#12002 therefore datachannel-wasm should add an explicit dependency on'$dynCall'to ensure it is present at runtime.However, it seems better to remove the reliance on the
dynCallAPI entirely. This PR replaces dynamicdynCallusage by themakeDynCallmacro, as the macro looks widely used in emscripten JS libraries and is de-facto public as explained in emscripten-core/emscripten#12732. It removes the dependency on the runtime method and should perform better.Fixes the possible need for
-sDYNCALLS=1described in #38