The path to tcpdf_filters.php can be parameterized#25
Open
Temptatio wants to merge 1 commit intopauln:masterfrom
Open
The path to tcpdf_filters.php can be parameterized#25Temptatio wants to merge 1 commit intopauln:masterfrom
Temptatio wants to merge 1 commit intopauln:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If one installs tecnickcom/TCPDF with composer, one currently has to place tcpdf_filters.php explicitly into the directory tree of the library. This might be a problem during installation via composer and packaging. Furthermore it breaks with the concept of libraries as unmodifiable parts of third parties.
This change allows existing software to be run as before and adds the possibility to provide a custom location for the required script tcpdf_filters.php to tcpdi_parser.php.