feat: Web compatibility #98
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markstreich
commented
Mar 25, 2025
markstreich
commented
- fixes Web compatibility #93
markstreich
commented
Mar 25, 2025
| "react-native-reanimated": "^3.2.0", | ||
| "release-it": "^14.2.2", | ||
| "typescript": "^4.1.3" | ||
| "typescript": "^4.9.5" |
Author
There was a problem hiding this comment.
main was failing for yarn typescript with the old version
markstreich
commented
Mar 25, 2025
| 'worklet'; | ||
| if (!isActive.value) return; | ||
| if (numberOfPointers !== 1) return; | ||
| if (numberOfPointers > 1) return; |
Author
There was a problem hiding this comment.
On web (with mouse), numberOfPointers is 0 (if I understand correctly, this was preventing two finger touches from triggering double clicks, so > 1 should have the same effect)
markstreich
commented
Mar 25, 2025
| const { height: h, width: w } = e.nativeEvent.source; | ||
| setImageDimensions({ height: h, width: w }); | ||
| onLoad={() => { | ||
| Image.getSize( |
Author
There was a problem hiding this comment.
nativeEvent.source doesn't work on web.
markstreich
commented
Mar 25, 2025
| setImageDimensions, | ||
| }: RenderItemInfo<{ uri: string }>) => { | ||
| return ( | ||
| <Image |
Author
There was a problem hiding this comment.
expo-image (at least this version) gives a bunch of errors on web, also the error in the main library was from defaultRenderImage, so switched to using that in the example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.