fix(plugin-seo): type Meta.image and extract shared MetaImageValue#17073
Open
Notorious-Ali wants to merge 1 commit into
Open
fix(plugin-seo): type Meta.image and extract shared MetaImageValue#17073Notorious-Ali wants to merge 1 commit into
Notorious-Ali wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Replaces the untyped
image?: anyon the plugin'sMetatype with a precise type, and extracts a sharedMetaImageValuetype so thatMeta.imageandGenerateImage's return value can no longer drift apart.Why?
Meta.imagewas typedanyHow?
In
packages/plugin-seo/src/types.ts:Meta.imageis nowimage?: MetaImageValueinstead ofany.GenerateImage's return type now reusesMetaImageValue | Promise<MetaImageValue>— structurally identical to the previous inline union, so there is no runtime/behavior change.In
packages/plugin-seo/src/exports/types.ts:MetaImageValuefrom the public types barrel so consumers can type image values consistently.Before:
After: